Skip to content

Conversation

@cvng
Copy link
Contributor

@cvng cvng commented Dec 14, 2023

What kind of change does this PR introduce?

add support for create operator

What is the current behavior?

panics

What is the new behavior?

parser returns

View log
DefineStmt { kind: ObjectOperator, oldstyle: false, defnames: [ Node { node: Some( String( String { sval: "+", }, ), ), }, ], args: [], definition: [ Node { node: Some( DefElem( DefElem { defnamespace: "", defname: "procedure", arg: Some( Node { node: Some( TypeName( TypeName { names: [ Node { node: Some( String( String { sval: "plusfunc", }, ), ), }, ], type_oid: 0, setof: false, pct_type: false, typmods: [], typemod: -1, array_bounds: [], location: 48, }, ), ), }, ), defaction: DefelemUnspec, location: 36, }, ), ), }, Node { node: Some( DefElem( DefElem { defnamespace: "", defname: "leftarg", arg: Some( Node { node: Some( TypeName( TypeName { names: [ Node { node: Some( String( String { sval: "int4", }, ), ), }, ], type_oid: 0, setof: false, pct_type: false, typmods: [], typemod: -1, array_bounds: [], location: 84, }, ), ), }, ), defaction: DefelemUnspec, location: 74, }, ), ), }, Node { node: Some( DefElem( DefElem { defnamespace: "", defname: "rightarg", arg: Some( Node { node: Some( TypeName( TypeName { names: [ Node { node: Some( String( String { sval: "int4", }, ), ), }, ], type_oid: 0, setof: false, pct_type: false, typmods: [], typemod: -1, array_bounds: [], location: 117, }, ), ), }, ), defaction: DefelemUnspec, location: 106, }, ), ), }, ], if_not_exists: false, replace: false, }

Additional context

waiting for the correct design in #72

@cvng cvng marked this pull request as draft December 14, 2023 17:56
@cvng cvng force-pushed the create-op branch 3 times, most recently from 9dbdc43 to 03e61c2 Compare December 17, 2023 13:54
@cvng cvng changed the base branch from main to feat/create-aggregate December 17, 2023 13:54
@cvng cvng marked this pull request as ready for review December 17, 2023 14:06
@cvng
Copy link
Contributor Author

cvng commented Dec 18, 2023

@psteinroe now that #72 is merged this one is also ready for review

@psteinroe psteinroe merged commit 22eeadd into supabase-community:feat/create-aggregate Dec 18, 2023
@cvng cvng deleted the create-op branch December 18, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants