chore(pgt_query): support system build #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
after reviewing the comments on our first attempt to add this project to homebrew (Homebrew/homebrew-core#218049), i realised that we can significantly improve the build in our homebrew recipe if we add
libpg_queryas a homebrew dependency (yes, it is available there as a formula).this PR adds a "dual build" to the build script of
pgt_query. IfLIBPG_QUERY_PATHis set, we link the library directly and skip the build.tested this locally.
once this is merged, I will publish a new release and create the pr for homebrew.