Skip to content

fix: do not display hover items when hovering over param #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2025
Merged

fix: do not display hover items when hovering over param #553

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b85c068
fixie fixie
juleswritescode Oct 10, 2025
68e958e
fix: do not shower hover info on sql params
juleswritescode Oct 10, 2025
308e34f
ok ok
juleswritescode Oct 10, 2025
f8ff42b
those were invalid filenames
juleswritescode Oct 10, 2025
542a9e0
Merge branch 'main' into fix/param-hover
juleswritescode Oct 13, 2025
0e58866
Merge branch 'main' into fix/param-hover
juleswritescode Oct 13, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ok ok
  • Loading branch information
@juleswritescode
juleswritescode committed Oct 10, 2025
commit 308e34f55d48a45dc38fd65efeab422a9ae762d2
4 changes: 0 additions & 4 deletions crates/pgt_hover/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,12 @@ pub struct OnHoverParams<'a> {
position = params.position.to_string()
))]
pub fn on_hover(params: OnHoverParams) -> Vec<String> {
println!("on hover!");

let ctx = pgt_treesitter::context::TreesitterContext::new(TreeSitterContextParams {
position: params.position,
text: params.stmt_sql,
tree: params.ts_tree,
});

println!("ctx {:#?}", ctx);

if let Some(hovered_node) = HoveredNode::get(&ctx) {
let items: Vec<Hoverable> = match hovered_node {
HoveredNode::Table(node_identification) => match node_identification {
Expand Down
Loading