Skip to content

fix(completions): cursor on dot, other issues #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2025
+90 −4
Merged

fix(completions): cursor on dot, other issues #359

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0701724
fix(completions): cursor on dot, other issues
juleswritescode Apr 21, 2025
0847f45
Merge branch 'fix/workflow-file' of https://github.com/supabase-commu…
juleswritescode Apr 21, 2025
e3e54e4
?
juleswritescode Apr 21, 2025
ac122a5
test belongs here
juleswritescode Apr 21, 2025
f24c072
refs
juleswritescode Apr 21, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refs
  • Loading branch information
@juleswritescode
juleswritescode committed Apr 21, 2025
commit f24c0724ede290483bf730ec8eba7e12c2b8187c
6 changes: 3 additions & 3 deletions crates/pgt_completions/src/sanitization.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,13 +275,13 @@ mod tests {
let input = "select * from private.";

// select * from private.| <-- on a dot
assert!(cursor_on_a_dot(&input, TextSize::new(22)));
assert!(cursor_on_a_dot(input, TextSize::new(22)));

// select * from private|. <-- before the dot
assert!(!cursor_on_a_dot(&input, TextSize::new(21)));
assert!(!cursor_on_a_dot(input, TextSize::new(21)));

// select * from private. | <-- too far off the dot
assert!(!cursor_on_a_dot(&input, TextSize::new(23)));
assert!(!cursor_on_a_dot(input, TextSize::new(23)));
}

#[test]
Expand Down