feat(completions): autocomplete for function types #155
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Autocompletions for functions! Some rules that are applied:
selectclause, we'll prefer function items over table itemsfromclause, we'll slightly prefer table itemsI refactored the
CompletionRelevanceagain; now we can update the score based on the completion item score.I also added docs to the SchemaCache's
Functionand changed the query. Some properties wereOptions, even though they should always be present:id,schemaetc. – please verify if I made any wrong assumptions 🙌Some extra stuff:
CompletionItem.preselectedfromOption<bool>to a simpleboolClauseTypeenumNote: I had to comment out an alphanumeric table test. The query generates a tree-sitter tree with an
ERROR, and the current node has anend_byte()that is at position 17, while the query only has a length of 14... will check in a separate PR, not sure why it even worked before 🤷