fetch user details after each successful sign in

[itswisdomagain]

Fetching user details immediately after a successful sign in is already done for SignInWithCustomTokenAsync:

firebase-authentication-dotnet/src/Firebase.Auth/FirebaseAuthProvider.cs

Lines 51 to 57 in f75ec11

	public async Task<FirebaseAuthLink> SignInWithCustomTokenAsync(string customToken)
	{
	string content = $"{{\"token\":\"{customToken}\",\"returnSecureToken\":true}}";
	FirebaseAuthLink firebaseAuthLink = await this.ExecuteWithPostContentAsync(GoogleCustomAuthUrl, content).ConfigureAwait(false);
	firebaseAuthLink.User = await this.GetUserAsync(firebaseAuthLink.FirebaseToken).ConfigureAwait(false);
	return firebaseAuthLink;
	}

This PR adds similar functionality to other sign in methods:

• SignInWithOAuthAsync
• SignInWithOAuthTwitterTokenAsync
• SignInWithGoogleIdTokenAsync
• SignInWithGoogleIdTokenAsync
• SignInWithEmailAndPasswordAsync

Fetching user details is not done for SignInAnonymouslyAsync as I believer each anonymous login creates a new user and there'd be no user details to fetch after such login.

Closes #21.

[Kapusch]

Thank you @itswisdomagain !

One question though, I've noticed this method in FirebaseAuthLink class :

firebase-authentication-dotnet/src/Firebase.Auth/FirebaseAuthLink.cs

Lines 72 to 78 in f75ec11

	public async Task RefreshUserDetails()
	{
	if (this.AuthProvider != null && !string.IsNullOrEmpty(this.FirebaseToken))
	{
	this.User = await this.AuthProvider.GetUserAsync(this.FirebaseToken).ConfigureAwait(false);
	}
	}

Wouldn't be good to use this instead ?

firebaseAuthLink.RefreshUserDetails(); 

[itswisdomagain]

They basically do the same thing.

The approach in this PR calls this.GetUserAsync from the AuthProvider class and assigns the result to firebaseAuthLink.User.

Whereas firebaseAuthLink.RefreshUserDetails() calls AuthProvider.GetUserAsync and assigns the result to this.user.

[bezysoftware]

Thx for the PR, I can merge after you resolve conflicts. Also note that brand new version is being developed in V4 branch

[itswisdomagain]

@bezysoftware Merge conflicts resolved. Just a reminder.

[bezysoftware]

Thanks, can you also pls bump the version to 3.5.0 in the csproj? I'll deploy it to nuget then

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[itswisdomagain]

Thanks, can you also pls bump the version to 3.5.0 in the csproj? I'll deploy it to nuget then

I somehow missed that comment. Will do.

[bezysoftware]

Published to nuget, should be available shortly, thanks!

[EmilAlipiev]

thats not a correct implementation. especially for facebook(possibly all other social media logins twitter, instagram etc.). You will get 2 problems.

1. firebaseAuthLink.User = await this.GetUserAsync(firebaseAuthLink.FirebaseToken).ConfigureAwait(false);
   Facebook doesnt return FirebaseToken but returns OauthAccessToken. FirebaseToken value is always null for facebook.
2. Biger problem is Firebase doesnt store facebook or any other social media (didnt test but probably same with Twitter) user information. This method throws 400 Bad request every time.