Doc improvements #12
Merged
Doc improvements #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
kuba-- reviewed Sep 25, 2018
common.go Outdated
| type RepublishConditions []RepublishConditionFunc | ||
| | ||
| // Comply checks if the Job fit in any of the defined conditions. | ||
| // Comply checks if the Job fits any of the defined conditions. |
There was a problem hiding this comment.
yeah that's better, I'll push the change
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
jfontan approved these changes Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes some typos.
Also modifies the description of
advertisedWindow, which was wrong describing as minimum instead of maximum number of unacknowledged jobs. Or I'm wildly misunderstanding what it does.