Implementation as packages and register pattern #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
smola reviewed May 9, 2018
register.go Outdated
| type BrokerBuilder func(uri string) (Broker, error) | ||
| | ||
| // Register registers a new BrokerBuilder to be used by NewBroker, this function | ||
| // should be used in an init function in the implementation packages sush as |
memory/memory.go Outdated
| func NewMemoryBroker() Broker { | ||
| return &memoryBroker{make(map[string]Queue)} | ||
| // NewMemoryBroker creates a new Broker for an in-memory queue. | ||
| func NewMemoryBroker() queue.Broker { |
There was a problem hiding this comment.
Given that it is on its own package, we might want to call this just NewBroker or New. Same with the AMQP one.
Signed-off-by: Máximo Cuadros <mcuadros@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation of the different queue to a pattern where allows extensibility without modification of the code. Allowing to register different implementation following the database pattern for the standard library
This is an example of the new usage, where the implementation should be imported: