This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Add date and time parsing #14
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Tested with Teensy 3.2
| Very good! I'll get this tested soon. Looks like your PR can't be merged directly. Was the loggerhead-instruments fork behind? I should be able to resolve the issues. |
| Thank you for this! I manually merged it. Is there a reason why startingSpot was removed from this line? I think it's correct since startingSpot was changed to zero but it's odd that the other lines were not also modified. |
| Should be included in next version v1.4.x. |
| I didn't look into the code of the pr, I just tested the fork from @loggerhead-instruments and it seemed to work nicely. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've created this pull request as I would really love to see the features discussed in this issue in the library. It's not my code, but the of @loggerhead-instruments . I tested the GetDateTime example sketch with UART on my ESP32 and all the time functions work properly.