Fix parsing of PHP_CodeSniffer output #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In commit 2fef12b "Fix psalm errors" the code to get the last line of the generated output was modified to work around psalm diagnostics, but in a way that actually broke its functionality. The `end()` function already returns the last element of an array, its return value is not meant to be used to index that array.
spaceemotion approved these changes May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In commit 2fef12b "Fix psalm errors" the code to get the last line of
the generated output was modified to work around psalm diagnostics, but
in a way that actually broke its functionality. The
end()functionalready returns the last element of an array, its return value is not
meant to be used to index that array.