Skip to content

Introduction to FOLDER_TREE_LENGTH config parameter #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sp1thas merged 8 commits into from
Oct 23, 2022
Merged

Introduction to FOLDER_TREE_LENGTH config parameter #4

sp1thas merged 8 commits into from
Oct 23, 2022

Conversation

@HemantSachdeva
Copy link
Contributor

@HemantSachdeva HemantSachdeva commented Oct 23, 2022

Resolves #1.

Signed-off-by: Hemant Sachdeva hemant.evolver@gmail.com
@HemantSachdeva
Introduction to FOLDER_TREE_LENGTH config parameter
a504245 
Resolves #1. Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@HemantSachdeva
piplines: Add newly introduced FOLDER_TREE_LENGTH config parameter
4e7799a 
Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@Simba-97 Simba-97 mentioned this pull request Oct 23, 2022
Closed
sp1thas
sp1thas requested changes Oct 23, 2022
View reviewed changes
Simba-97 and others added 2 commits October 23, 2022 19:35
@Simba-97 @HemantSachdeva
docs: Add new tree length config parameter
9175644 
Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@HemantSachdeva
hash: Add back dir name
cc92640 
Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
sp1thas
sp1thas approved these changes Oct 23, 2022
View reviewed changes
Copy link
Owner

@sp1thas sp1thas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution @HemantSachdeva
sp1thas
sp1thas requested changes Oct 23, 2022
View reviewed changes
Copy link
Owner

@sp1thas sp1thas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more thing @HemantSachdeva apply black formatting run
@HemantSachdeva
hash: format it with black
05caf3a 
Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@HemantSachdeva
Copy link
Contributor Author

HemantSachdeva commented Oct 23, 2022

Hope we are good to go now.
It was a nice experience for me :)
@HemantSachdeva
tests: trees: Add newly introduced length parameter
00ba0c6 
Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@HemantSachdeva
Copy link
Contributor Author

HemantSachdeva commented Oct 23, 2022

Oh man this black 😂🫡
@HemantSachdeva
test: trees: format with black
453e294 
Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2022 •
edited
Loading

Codecov Report

Base: 69.56% // Head: 68.42% // Decreases project coverage by -1.14% ⚠️

Coverage data is based on head (2896ffc) compared to base (216198a).
Patch coverage: 60.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@ Coverage Diff @@ ## master #4 +/- ## ========================================== - Coverage 69.56% 68.42% -1.15%  ========================================== Files 6 6 Lines 92 95 +3 ========================================== + Hits 64 65 +1  - Misses 28 30 +2
Flag Coverage Δ
unittests 68.42% <60.00%> (-1.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/scrapy_folder_tree/config.py 100.00% <ø> (ø)
src/scrapy_folder_tree/pipelines.py 50.84% <0.00%> (-1.79%) ⬇️
src/scrapy_folder_tree/trees/hash.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.
@HemantSachdeva
test: trees: Add test to check default length value
2896ffc 
Signed-off-by: Hemant Sachdeva <hemant.evolver@gmail.com>
@sp1thas sp1thas merged commit 1121c09 into sp1thas:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@HemantSachdeva @codecov-commenter @sp1thas @Simba-97