You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixestest 6, "allocate_as_barier_proc", failing #28 : When CMake release types are passed to CMake, optimization flags are added to the gfortran compiler, which trigger bugs in GCC for GFortran < 5.4
Normally, once we're on the Github Flow workflow, some of these may have deserved their own branch (i.e., issue-28-gcc-flag-bug, issue-31-make-clean, issue-56-bad-links but in the interest of time and paying down technical debt, I have applied all of these on the same branch, in the same PR.)
It seemed as though this patch was not fixing the issue. I've added some more debug output and force pushed (to my private branch) an updated version. Hopefully tests pass on the first try.
See #28 and #27 for further discussion as well PR Homebrew/legacy-homebrew#46547Fixes#28 Change default optimization flags for GFortran when the user selects a build type, and ensure that all optimization is always off, until GCC patches the GFortran bug. Signed-off-by: Izaak Beekman <zbeekman@gmail.com>
I think I have fixed the issue with test 6, however right now Homebrew's CDN seems to be down, and as a consequence brew install mpich is trying to install from source which times out. As a work around, I'm also going to add in my fix for #51 because it grabs the bottles from Github, which acts as our CDN through uploading them to #65.
Merging this even though, on occasion, #28 is still failing on OS X. If this continues, we can tell Travis-CI to ignore the outcome of the OS-X build; it will still do it, but failures there won't impact the build status...
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make clean#31 : Generate files at CMake config time in the binary tree not the source tree. Also don't delete them withmake cleanNormally, once we're on the Github Flow workflow, some of these may have deserved their own branch (i.e., issue-28-gcc-flag-bug, issue-31-make-clean, issue-56-bad-links but in the interest of time and paying down technical debt, I have applied all of these on the same branch, in the same PR.)