Skip to content

Conversation

iyiolacak
Copy link
Contributor

@iyiolacak iyiolacak commented Aug 29, 2025

  • I have read the Contribution guide
  • This PR references an issue (except for typos, broken links, or other minor problems)

Description (required)

Fix a broken link path that leads new users to a 404.

How I encountered it

  • From Google I landed on https://www.solidjs.com/guides/getting-started
  • That page says: “We’re working on new docs. You can check out our new beginner tutorial here…”
    - The “here” link points to https://docs.solidjs.com/guides/tutorials/getting-started-with-solid/welcome
  • That URL returned 404 on the new docs site.

What this PR does

  • Adds a route at src/routes/guides/tutorials/getting-started-with-solid/welcome.tsx
  • Issues an HTTP redirect to /quick-start (via standard Web Response with Location)
  • Includes a client-side fallback (window.location.replace) for SPA navigations

Testing

  • Local dev: pnpm dev
  • Visiting /guides/tutorials/getting-started-with-solid/welcome redirects to /quick-start
  • Client navigation also redirects via the fallback

Related issues & labels

  • Suggested label(s) (optional): documentation, bug, good first issue
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Aug 29, 2025

Deploy Preview for solid-docs ready!

Name Link
🔨 Latest commit 3842fd9
🔍 Latest deploy log https://app.netlify.com/projects/solid-docs/deploys/68f97696c494400008ad3b44
😎 Deploy Preview https://deploy-preview-1231--solid-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@iyiolacak iyiolacak force-pushed the fix/welcome-404-redirect branch from 7ba4c90 to 8e0a8dd Compare August 29, 2025 01:29
@brenelz
Copy link
Collaborator

brenelz commented Aug 30, 2025

Couldn't we just fix the link on the old docs instead of setting up a redirect here for the bad link?

@iyiolacak
Copy link
Contributor Author

iyiolacak commented Aug 30, 2025

This would at least guarantee, if this link was in use somewhere else in the internet or in the SolidJS docs.

I am happy to just change the href if you want to but I wasn't sure if this URL was used on somewhere else both in the docs or external web.

@LadyBluenotes
Copy link
Member

@brenelz
Copy link
Collaborator

brenelz commented Sep 2, 2025

@iyiolacak did you want to make this change?

@iyiolacak
Copy link
Contributor Author

@brenelz Yup, that'd be better for consistency. I'll move it into legacy-routes-redirect.ts in my next commit and rollback the new route.

@atilafassina atilafassina added site improvement Something that improves the website functionality wait to merge labels Oct 20, 2025
@atilafassina
Copy link
Member

Added a few labels to indicate this is pending review and added @/LadyBluenotes as reviewer so you can ping when the redirect is moved to the middleware

This way the PR doesn't look like it's ready to merge :)

@iyiolacak iyiolacak force-pushed the fix/welcome-404-redirect branch from 13a8fff to 3842fd9 Compare October 23, 2025 00:28
@iyiolacak
Copy link
Contributor Author

@LadyBluenotes Sorry for late push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

site improvement Something that improves the website functionality wait to merge

4 participants