feat: convolver impl #533
Merged
feat: convolver impl #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/react-native-audio-api/common/cpp/audioapi/libs/FFTConvolver/README.md Dismissed Show dismissed Hide dismissed
packages/react-native-audio-api/common/cpp/audioapi/libs/FFTConvolver/README.md Dismissed Show dismissed Hide dismissed
mdydek commented Jun 30, 2025
Current stateRight now it does not work correctly filter is not being applied as it should be. IdeaIt would be nice to strip out the TestCaseIt is nice to test on simple defered echo filter. IR being the filter and |
maciejmakowski2003 requested changes Oct 20, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Outdated Show resolved Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.h Outdated Show resolved Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Outdated Show resolved Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/dsp/Convolver.cpp Outdated Show resolved Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Show resolved Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Show resolved Hide resolved
vltkv reviewed Oct 21, 2025
vltkv requested changes Oct 21, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Outdated Show resolved Hide resolved
vltkv requested changes Oct 21, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Show resolved Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Show resolved Hide resolved
poneciak57 requested changes Oct 27, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/effects/ConvolverNode.cpp Show resolved Hide resolved
poneciak57 approved these changes Oct 29, 2025
packages/react-native-audio-api/common/cpp/audioapi/core/BaseAudioContext.cpp Outdated Show resolved Hide resolved
packages/react-native-audio-api/common/cpp/audioapi/dsp/Convolver.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes RNAA-136, RNAA-305
Introduced changes
convolver, which allows to do linear convolution algorithm with associated buffer, which can help achieve f.e. reverb soundChecklist