Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Overview
Popoversupports arefprop that doesn't seem to be documented or typed.Here is a codesandbox that showcases the ref actually working at run time, but with type errors. This PR addresses those errors by:
PopoverReftype that has the signatures foropenandclosemethodsrefprop toPopoverPropsI also tweaked the definition for
childredprop. Specifically, thegetRefprop passed to children to use the newPopoverRefinstead of the genericHTMLElement.Since the type definition for select menu relies on
PopoverProps, I added therefto the list of omitted properties as that component doesn't actually have any ref-related functionality.The changes can be tested by trying to pass a ref created by
useRef<PopoverRef>and making sure there are no type errors related to callingopenorclose.Documentation