Skip to content

Remove incorrect @NonNull annotation from mitigation field #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2021
Merged

Remove incorrect @NonNull annotation from mitigation field #4

merged 1 commit into from
May 11, 2021

Conversation

@J12934
Copy link
Member

@J12934 J12934 commented May 11, 2021

Closes #3
@J12934 J12934 added the bug Something isn't working label May 11, 2021
@J12934 J12934 requested a review from wurstbrot May 11, 2021 18:34
@J12934 J12934 self-assigned this May 11, 2021
@wurstbrot
Copy link
Contributor

wurstbrot commented May 11, 2021 •
edited
Loading

We can try it out, I assume that @nonnull is correct, because defectdojo enforces a value in the UI. That's why I recommended an empty value.
In the API it is allowed to be null, so it is ok.
I assume the error happens in the fetch of the findings, not in the upload.
@wurstbrot wurstbrot merged commit bae1b5a into main May 11, 2021
@wurstbrot wurstbrot deleted the fix/null-mitigation branch May 12, 2021 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

3 participants

@J12934 @wurstbrot