Skip to content

Conversation

@m-1-k-3
Copy link
Contributor

@m-1-k-3 m-1-k-3 commented May 6, 2022

A quick EMBA section for the guide.

I took the FACT section as template. As the document is growing should we move the tools section into a separate md file?

@scriptingxss
Copy link
Owner

scriptingxss commented May 18, 2022

Yep totally agree we should move into a separate file structure. The current structure was due to its dependency on GitBook. Its been awhile since Ive had the opportunity to move to GitHub Pages.

I see that images were added to the assets folder but I couldn't find if they were included inside the README.md as part of the walkthroughs. Did I miss something? Edit: Yep I missed them sorry about that.

@m-1-k-3 m-1-k-3 requested a review from scriptingxss May 18, 2022 06:05
Copy link
Owner

@scriptingxss scriptingxss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you looks great! :D

@scriptingxss scriptingxss merged commit ae4b96d into scriptingxss:master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants