Skip to content

Conversation

bifeldy
Copy link

@bifeldy bifeldy commented Apr 20, 2023

Hello

I'm continuing #52
Example already on readme.md file

Thanks.

Hello,

I just want to know, how to run behind reverse proxy with some prefix path. For example I want is :: http://xxx.xxx.xxx.xxx/nginx-ui

Is there any environment variable to pass ? Something like APP_PATH_PREFIX ?

Thanks 🙂

@schenkd schenkd self-assigned this Apr 24, 2023
@schenkd schenkd added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 24, 2023
@schenkd schenkd linked an issue Apr 24, 2023 that may be closed by this pull request
Copy link
Owner

@schenkd schenkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bifeldy, thank you very much for your contribution!
I'm about to accept this PR if you adapt the volume mounts in the README.md to a unix path and remove the docker-compose.windows.yml.
I can understand to have this one in your private repo, but in this I don't want to support any windows specific adjustments since I don't have a windows system to test things on.

Thank you very much :)


bifeldy-net:
name: bifeldy-net
external: true No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bifeldy, could you please remove this one? It's not generic since it's assumes that

  1. a drive D:/ is always the target to mount
  2. you are using your username as a network name

btw. everything that's in the repo need maintenance and I don't want to support on issues with docker-compose and windows.

I'm okay with adding it in a seperate section in the README.md to provide an example for people that are using windows.

Best David

README.md Outdated
# ports:
# - 8080:8080
volumes:
- D:/_data/_docker/nginx:/etc/nginx
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you adjust the volume mounts to a unix path? I don't want to get requests related to windows support since I don't have a windows machine where I could test it. Thanks mate!

@bifeldy
Copy link
Author

bifeldy commented May 3, 2023

Hi @schenkd

Hopefully, you check the newly updated file

Thanks.

@bifeldy bifeldy changed the title Location prefix behind reverse proxy Location prefix behind reverse proxy + Button For Reload Configuration May 10, 2023
@bifeldy bifeldy requested a review from schenkd July 13, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

2 participants