Skip to content

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Sep 18, 2014

No description provided.

@gzm0
Copy link
Contributor Author

gzm0 commented Sep 18, 2014

Review by @sjrd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit conversion between

@sjrd
Copy link
Member

sjrd commented Sep 18, 2014

That's all.

@gzm0
Copy link
Contributor Author

gzm0 commented Sep 18, 2014

Updated

@sjrd
Copy link
Member

sjrd commented Sep 18, 2014

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 0.5.5, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, it should indeed ^^ Thanks.

@gzm0
Copy link
Contributor Author

gzm0 commented Sep 19, 2014

Updated

@sjrd
Copy link
Member

sjrd commented Sep 19, 2014

LGTM

@gzm0
Copy link
Contributor Author

gzm0 commented Sep 19, 2014

I will merge this once all artifacts are published and I copied the API doc to scala-js.org

@sjrd
Copy link
Member

sjrd commented Sep 19, 2014

I'll update the tutorial.

@sjrd
Copy link
Member

sjrd commented Sep 19, 2014

Trivial change from 0.5.4 to 0.5.5 in project/plugins.sbt: https://github.com/scala-js/scalajs-tutorial/tree/develop
Not actually tested yet, waiting for everything to be published.

gzm0 added a commit that referenced this pull request Sep 19, 2014
@gzm0 gzm0 merged commit 5aeacf9 into scala-js:master Sep 19, 2014
@gzm0 gzm0 deleted the release-0.5.5 branch September 19, 2014 08:17
@gzm0
Copy link
Contributor Author

gzm0 commented Sep 19, 2014

@sjrd You are green to test the tutorial

@sjrd
Copy link
Member

sjrd commented Sep 19, 2014

Tested and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants