Skip to content

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Aug 29, 2014

No description provided.

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2014

Review by @gzm0 if you still have Internet atm.

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2014

We have to wait for @lihaoyi to publish a new version of uTest built against 0.5.4, because their respective sbt plugins are not binary compatible :-(

@lihaoyi
Copy link
Contributor

lihaoyi commented Aug 29, 2014

Yeah, will release one as soon as I have time...

On Fri, Aug 29, 2014 at 8:32 AM, Sébastien Doeraene <
notifications@github.com> wrote:

We have to wait for @lihaoyi https://github.com/lihaoyi to publish a
new version of uTest built against 0.5.4, because their respective sbt
plugins are not binary compatible :-(


Reply to this email directly or view it on GitHub
#80 (comment)
.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

explicitly setting

@gzm0
Copy link
Contributor

gzm0 commented Aug 29, 2014

That's all. (I haven't verified if the changes are in the right commit)

@gzm0
Copy link
Contributor

gzm0 commented Aug 29, 2014

Actually, we could write in the release notes that uTest has to be updated due to the sbt plugin. This will probably avoid a lot of trouble for our users and support requests for us.

@lihaoyi
Copy link
Contributor

lihaoyi commented Aug 29, 2014

I just published utest 0.2.3 to sonatype, with no difference other than that it's based off of 0.5.4 rather than 0.5.3

com-lihaoyi/utest@7bea468

It should become available soon, if you want to try it out for testing

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2014

Thanks a lot!

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2014

OK, it works :-)

@lihaoyi
Copy link
Contributor

lihaoyi commented Aug 29, 2014

Cool! So I guess for my docs I should say "utest 0.2.2 supports sjs 0.5.3,
utest 0.2.3 supports sjs 0.5.4"?

On Fri, Aug 29, 2014 at 9:58 AM, Sébastien Doeraene <
notifications@github.com> wrote:

OK, it works :-)


Reply to this email directly or view it on GitHub
#80 (comment)
.

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2014

Cool! So I guess for my docs I should say "utest 0.2.2 supports sjs 0.5.3, utest 0.2.3 supports sjs 0.5.4"?

Yes, that's right.

@sjrd
Copy link
Member Author

sjrd commented Aug 29, 2014

Updated.

I also updated the develop branch of the tutorial repo
https://github.com/scala-js/scalajs-tutorial/tree/develop

sjrd added a commit that referenced this pull request Aug 29, 2014
@sjrd sjrd merged commit 003eee5 into scala-js:master Aug 29, 2014
@sjrd sjrd deleted the release-0.5.4 branch August 29, 2014 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants