Skip to content

Version 0.5.3. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2014
Merged

Version 0.5.3. #69

merged 1 commit into from
Jul 30, 2014

Conversation

sjrd
Copy link
Member

@sjrd sjrd commented Jul 30, 2014

No description provided.

@sjrd
Copy link
Member Author

sjrd commented Jul 30, 2014

Review by @gzm0
@sjrd
Copy link
Member Author

sjrd commented Jul 30, 2014

Possibly also @lihaoyi
@sjrd
Copy link
Member Author

sjrd commented Jul 30, 2014

And the updated develop branch in the tutorial:
https://github.com/scala-js/scalajs-tutorial/commits/develop
gzm0
gzm0 reviewed Jul 30, 2014
View reviewed changes
_posts/news/2014-07-30-announcing-scalajs-0.5.3.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on our standard benchmarks?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I meant this standard. But I am open to suggestions for better wording.
@gzm0
Copy link
Contributor

gzm0 commented Jul 30, 2014

That's all
@gzm0
Copy link
Contributor

gzm0 commented Jul 30, 2014

develop in scalajs-tutorial LGTM
@sjrd
Copy link
Member Author

sjrd commented Jul 30, 2014

Updated.
@gzm0
Copy link
Contributor

gzm0 commented Jul 30, 2014

LGTM
@sjrd
Copy link
Member Author

sjrd commented Jul 30, 2014

Perfect timing, the publishing just finished. Updating example app and these things, and then I'll announce.
@gzm0
Copy link
Contributor

gzm0 commented Jul 30, 2014

Don't forget the APIs
@sjrd
Copy link
Member Author

sjrd commented Jul 30, 2014

No, no, I'm doing that now.
sjrd added a commit that referenced this pull request Jul 30, 2014
@sjrd
Merge pull request #69 from sjrd/release-0.5.3
1dba349 
Version 0.5.3.
@sjrd sjrd merged commit 1dba349 into scala-js:master Jul 30, 2014
@sjrd sjrd deleted the release-0.5.3 branch July 30, 2014 19:09
lihaoyi
lihaoyi reviewed Jul 30, 2014
View reviewed changes
_posts/news/2014-07-30-announcing-scalajs-0.5.3.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this is a bit late, but I don't understand this and the following lines. Is java.net.URI one of the classes that's in javalib-ex? If it is, change it to "These additional Java classes" would make it more clear =)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's only DataInputStream, as the sentence a few lines below says:

Currently, the only additional class is java.io.DataInputStream.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok then, I completely missed that when skimming.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@sjrd @gzm0 @lihaoyi