Skip to content

Do not expose generated dev docker site to the internet #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2023
Merged

Do not expose generated dev docker site to the internet #618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Do not expose generated dev docker site to the internet 
By default, published docker ports "bind" to all inbound addresses. We restrict to localhost to avoid exposing the site to the internet. Note that malicious same L2 participants can still reach the container due to: moby/moby#45610
  • Loading branch information
@gzm0
gzm0 committed Sep 23, 2023
commit 2fd22e9b4b0ad3ff948cefa4f10e933a8ff0fa5f
2 changes: 1 addition & 1 deletion docker-compose.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ services:
jekyll:
build: .
ports:
- '4000:4000'
- '127.0.0.1:4000:4000'
volumes:
- .:/srv/jekyll:ro