Skip to content

Conversation

@sjrd
Copy link
Member

@sjrd sjrd commented Sep 15, 2022

No description provided.

@sjrd sjrd requested a review from gzm0 September 15, 2022 08:31
@sjrd sjrd force-pushed the scalajs-1.11.0 branch 2 times, most recently from 74bf22d to 77366f4 Compare September 15, 2022 08:51
Copy link
Contributor

@gzm0 gzm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor things

title: Announcing Scala.js 1.11.0
category: news
tags: [releases]
permalink: /news/2021/12/10/announcing-scalajs-1.11.0/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong permalink?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch!

}
{% endhighlight %}

This may have significant performance impacts in fullLink, like other compliant behaviors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performance impact (no s)?

The initial value of the field, as well as any other assignments to it, are still evaluated for their side effects.
That code can only be removed if the optimizer can prove that it is pure.

### The sbt setting `envVars` is taken into account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I look at this: should this be under changes with compat concerns? A build might break if the jsenv refuses an existing setting

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, that is a good point. I moved it and added a sentence about that.

@sjrd sjrd merged commit e972a17 into scala-js:main Sep 15, 2022
@sjrd sjrd deleted the scalajs-1.11.0 branch September 15, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants