Skip to content

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Jun 30, 2014

No description provided.

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 30, 2014

Review by @sjrd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also mention that this allows to use js.Dictionary as a Map by calling its methods directly, e.g., iterate over the pairs key/value with a for comprehension. This is what people wanted mostly.

@sjrd
Copy link
Member

sjrd commented Jun 30, 2014

That's all.

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 30, 2014

Updated

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 30, 2014

Please also review the develop branch of scalajs-tutorial

@sjrd
Copy link
Member

sjrd commented Jun 30, 2014

LGTM for this one. 2 comments on scalajs-tutorial at scala-js/scalajs-tutorial@49a3b99

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 30, 2014

I forgot to upgrade the Scala.js version... :(

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 30, 2014

Updated (both here and scalajs-tutorial)

@sjrd
Copy link
Member

sjrd commented Jun 30, 2014

LGTM (both)

@sjrd
Copy link
Member

sjrd commented Jun 30, 2014

Anything else to do, or can we merge and announce?

@gzm0
Copy link
Contributor Author

gzm0 commented Jun 30, 2014

We can merge and announce.

gzm0 added a commit that referenced this pull request Jun 30, 2014
@gzm0 gzm0 merged commit 67fb361 into scala-js:master Jun 30, 2014
@gzm0 gzm0 deleted the release-0.5.1 branch June 30, 2014 16:13
@gzm0
Copy link
Contributor Author

gzm0 commented Jun 30, 2014

:( I forgot the release button... :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That link is dead. Should be {{ BASE_PATH }}/news/2014/06/13/announcing-scalajs-0.5.0/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Fixing right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants