Document dynamic module splitting #538
Conversation
doc/project/module.md Outdated
| | ||
| Create modules that are as small as possible. | ||
| The smallest unit of splitting is a Scala class. | ||
| The smallest unit of splitting is a Scala class (see [Splitting Granularity](#Splitting Granularity) below for more). |
There was a problem hiding this comment.
Is this the correct way to link to an anchor?
There was a problem hiding this comment.
Yes, except that the titles are converted to something #splitting-granularity. I don't try to predict it, and instead generate then inspect the page with a browser's inspection tools...
| I still need another self-review pass. |
doc/project/module.md Outdated
| | ||
| ### Module Split Styles | ||
| | ||
| So far, we have seen public modules and dynamic import boundaries can be defined. |
There was a problem hiding this comment.
| So far, we have seen public modules and dynamic import boundaries can be defined. | |
| So far, we have seen how public modules and dynamic import boundaries can be defined. |
doc/project/module.md Outdated
| * `main.js`: public module, containing the export of `onClick`. | ||
| * many internal small modules (~150 for this example), approximately one per class. | ||
| | ||
| Observe that in this split style, dynamic import boundaries do not affect splitting because the modules are already as small as possible. |
There was a problem hiding this comment.
I don't understand this sentence. :s
There was a problem hiding this comment.
I have tried to clarify. PTAL
There was a problem hiding this comment.
(maybe it doesn't need to be there and I can just drop it)
There was a problem hiding this comment.
Hum, OK, now I understand. But I'm not sure it's clear for a user. Perhaps add something like "Dynamic import boundaries are still important for dynamic loading."? On a first reading, it sounds like this paragraph says that dynamic imports are irrelevant with SmallestModules. So it's confusing.
Perhaps even consider removing this paragraph altogether? I'm not sure it brings any relevant value to a user.
gzm0 force-pushed the document-dynamic-module-splitting branch from b605e60 to aea8422 Compare gzm0 force-pushed the document-dynamic-module-splitting branch from aea8422 to 1183101 Compare 
2 participants
No description provided.