Skip to content

Update tutorial for Scala.js 1.3.x #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2020
Merged

Update tutorial for Scala.js 1.3.x #527

merged 1 commit into from
Dec 8, 2020

Conversation

@gzm0
Copy link
Contributor

@gzm0 gzm0 commented Dec 8, 2020

This basically means:

  • Using xLinkJS instead of xOptJS
  • Include JS code from the linked directory
@gzm0 gzm0 requested a review from sjrd December 8, 2020 10:44
@gzm0
Copy link
Contributor Author

gzm0 commented Dec 8, 2020

https://github.com/scala-js/scalajs-tutorial/tree/dev-1.3.x to be pushed to 1.x (current 1.x. is already snapshotted as 1.2.x).
sjrd
sjrd approved these changes Dec 8, 2020
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here look good. There is a problem in the Step 6: Testing commit in the repo, though: scala-js/scalajs-tutorial@1b86942#diff-8fd74420ca55aa91d4c53775d2a55a999c405b5a4fafeaf73b7f0ef83e1f3b0c
doc/tutorial/basic/index.md Outdated
### Generate JavaScript

To generate a single JavaScript file using sbt, just use the `fastOptJS` task:
To generate JavaScript using sbt, just use the `fastLinkJS` task:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're here:

Suggested change
To generate JavaScript using sbt, just use the `fastLinkJS` task:
To generate JavaScript using sbt, use the `fastLinkJS` task:

?
@gzm0
Update tutorial for Scala.js 1.3.x
1114c3a 
This basically means: - Using xLinkJS instead of xOptJS - Include JS code from the linked directory
@gzm0
Copy link
Contributor Author

gzm0 commented Dec 8, 2020 •
edited
Loading

I have updated the branch in the tutorial repo and addressed the suggestion.
@sjrd sjrd merged commit b408f27 into scala-js:master Dec 8, 2020
@gzm0 gzm0 deleted the update-tutorial branch December 8, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@gzm0 @sjrd