Announcing Scala.js 1.0.0. #478

sjrd · 2020-02-11T18:56:55Z

And update the website to use 1.x by default everywhere.

The tutorial is duplicated, with one version for 1.x (the default), and a legacy version for 0.6.x.

Not to be merged yet, but review welcome :)

mushtaq · 2020-02-12T04:12:00Z

_posts/news/2020-02-19-announcing-scalajs-1.0.0.md

+After 7 years of development, including 5 years of stability within the 0.6.x series, we are finally ready to present Scala.js 1.0.0.
+Quoting Antoine de Saint-Exupéry,
+
+> Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away.


👍 ❤️ Rigor and obsession in the Scala.js development process is an example for all of us emulate! Thank you!

gzm0 · 2020-02-12T07:07:33Z

doc/api.md

+* [scalajs-test-adapter]({{ site.production_url }}/api/scalajs-sbt-test-adapter/latest/org/scalajs/testadapter/index.html)
+* [sbt-scalajs]({{ site.production_url }}/api/sbt-scalajs/latest/#org.scalajs.sbtplugin.package)
+* [sbt-scalajs-env-phantomjs]({{ site.production_url }}/api/sbt-scalajs-env-phantomjs/latest/#org.scalajs.jsenv.phantomjs.sbtplugin.package)
+* [sbt-jsdependencies]({{ site.production_url }}/api/sbt-jsdependencies/latest/#org.scalajs.jsdependencies.sbtplugin.package)


Have you considered removing the projects that are not in the core repo from this list? Since they will observe a different release schedule, they might best be put elsewhere? Just like the DOM and jQuery API below?

gzm0 · 2020-02-13T17:04:18Z

doc/tutorial/basic/index.md

+ org.scalajs.jsenv.Input.Script(file("./jquery.js").toPath)
+Compile / jsEnvInput := jQueryScript +: (Compile / jsEnvInput).value
+Test / jsEnvInput := jQueryScript +: (Test / jsEnvInput).value
+{% endhighlight %}


This is a bit problematic IMO. We really don't want anybody to think this is a good way to use Scala.js, do we?

How hard would it be to:

Not rely on a bare JS library.

Use scala-js-bundler in the tutorial.

Note that I haven't reviewed in detail yet.

It highlights a limitation of how we set up the jsEnvInput setting. We should initialize it to Nil in the no-configuration scope, and add the linked file in each configuration. That way we would only have to write

jsEnvInput += Input.Script(file("./jquery.js").toPath)

in this build.

We can improve that in 1.0.1, but for 1.0.0 we're stuck with this suboptimal config :(

Not rely on a bare JS library.

That would defeat the purpose of that entire section. Of course we can remove all the section about jQuery, and keep using the DOM until the end. Maybe that would be better?

Use scala-js-bundler in the tutorial.

That's probably going a step too far for this tutorial, which in my opinion lays the ground knowledge of how Scala.js work, and which every Scala.js user needs to know.

But I can write an alternative story where we do that, for comparison.

keep using the DOM until the end. Maybe that would be better?

That was my thinking as well. It would avoid some of the boilerplate of dealing with native JS libs. We should defer to the scalajs-bundler documentation for that.

I have pushed a commit that changes the tutorial to stick to standard DOM, rather than using jQuery. It goes with the following branch of the scalajs-tutorial repo: https://github.com/scala-js/scalajs-tutorial/commits/develop-1.x-no-jquery

Looking at it now, I actually think it's much better overall :)

gzm0 · 2020-02-13T17:08:31Z

_posts/news/2020-02-19-announcing-scalajs-1.0.0.md

+* `relativeSourceMaps`
+* `scalaJSOptimizerOptions`
+
+Finally, if you are still using sbt 0.13.x, you will have to upgrade to sbt 1.2.1 or later (as of this writing, the latest release is 1.3.4).


1.3.8? (taken from below).

gzm0 · 2020-02-13T17:09:20Z

_posts/news/2020-02-19-announcing-scalajs-1.0.0.md

+
+You will not be able to use Scala.js 1.0.0 with sbt 0.13.x.
+You will have to upgrade to sbt 1.2.1 or later.
+As of this writing, the latest version is 1.3.8.


Maybe put this to the bottom since it was already mentioned?

gzm0 · 2020-02-13T17:10:26Z

_posts/news/2020-02-19-announcing-scalajs-1.0.0.md

+
+* Scala 2.10.x is not supported at all,
+* Only 2.11.12 is still supported in the 2.11.x series, and
+* 2.12.1 and following are supported in the 2.12.x series, but not 2.12.0.


This might be a useful thing to mention in "before you upgrade": Upgrading the Scala version can (and should) be done before upgrading Scala.js to minimize simultaneous changes.

gzm0 · 2020-02-13T17:14:11Z

_posts/news/2020-02-19-announcing-scalajs-1.0.0.md

+
+Scala.js 1.x consolidates all of that into one simple task key `jsEnvInput` of type `Seq[org.scalajs.jsenv.Input]`, where an `Input` is an ADT with the following possible alternatives:
+
+* `Input.Scripts(script)`: a JavaScript file to load as a script


Input.Script?

This allows users to simply write jsEnvInput += Input.Script(myJSLibrary) in their build. Discovered while writing the tutorial: scala-js/scala-js-website#478 (comment)

sjrd · 2020-02-14T15:36:42Z

@gzm0 I believe I have addressed all your comments.

gzm0

Only minor nits.

I have reviewed https://github.com/scala-js/scalajs-tutorial/commits/develop-1.x-no-jquery as well.

gzm0 · 2020-02-14T16:06:02Z

doc/tutorial/basic/index.md

+We can avoid this issue by building the UI directly from the Scala.js code.

-In your `build.sbt`, set:
+Instead of prepare the button in the HTML, we can add the following code to the `main` method in Scala.js:


Instead of preparing

gzm0 · 2020-02-14T16:13:43Z

doc/tutorial/basic/index.md


- val button = jQuery("button:contains('Click me!')")
- assert(button.length == 1)
+ val button = document.querySelector("button")


Cast this to HTMLElement (or HTMLButtonElement) so you can call click()?

gzm0 · 2020-02-14T16:16:25Z

doc/tutorial/basic/index.md

-jsDependencies +=
- "org.webjars" % "jquery" % "2.2.1" / "jquery.js" minified "jquery.min.js"
+val button = document.createElement("button")
+button.textContent = "Click me!"


In appendPar we seem to use document.createTextNode (which seems unnecessarily verbose). Is this inconsistency deliberate?

No, it was not intended. The code in appendPar is much older, and perhaps at the time textContent did not exist yet. I have changed appendPar to use textContent a well.

sjrd · 2020-02-14T17:17:07Z

Updated to address the nits, and squashed all in one commit.

This allows users to simply write jsEnvInput += Input.Script(myJSLibrary) in their build. Discovered while writing the tutorial: scala-js/scala-js-website#478 (comment)

And update the website to use 1.x by default everywhere. The tutorial is duplicated, with one version for 1.x (the default), and a legacy version for 0.6.x.

sjrd requested a review from gzm0 February 11, 2020 18:56

mushtaq reviewed Feb 12, 2020

View reviewed changes

sjrd force-pushed the scalajs-1.0.0 branch 6 times, most recently from fa167be to bf828c9 Compare February 13, 2020 17:04

gzm0 requested changes Feb 13, 2020

View reviewed changes

gzm0 mentioned this pull request Feb 14, 2020

Set jsEnvInput without configuration in project scope scala-js/scala-js#3961

Merged

sjrd force-pushed the scalajs-1.0.0 branch 2 times, most recently from a3202b5 to 882bc2c Compare February 14, 2020 12:29

sjrd requested a review from gzm0 February 14, 2020 15:36

gzm0 approved these changes Feb 14, 2020

View reviewed changes

sjrd force-pushed the scalajs-1.0.0 branch from a7a7e65 to f051980 Compare February 14, 2020 17:15

sjrd force-pushed the scalajs-1.0.0 branch from f051980 to a20d8d7 Compare February 15, 2020 13:45

Announcing Scala.js 1.0.0.

cbc2a65

And update the website to use 1.x by default everywhere. The tutorial is duplicated, with one version for 1.x (the default), and a legacy version for 0.6.x.

sjrd force-pushed the scalajs-1.0.0 branch from a20d8d7 to cbc2a65 Compare February 24, 2020 09:06

gzm0 approved these changes Feb 24, 2020

View reviewed changes

sjrd changed the title ~~DO NOT MERGE Announcing Scala.js 1.0.0.~~ Announcing Scala.js 1.0.0. Feb 25, 2020

sjrd merged commit b9d3f79 into scala-js:master Feb 25, 2020

sjrd deleted the scalajs-1.0.0 branch February 25, 2020 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Announcing Scala.js 1.0.0. #478

Announcing Scala.js 1.0.0. #478

Uh oh!

sjrd commented Feb 11, 2020

mushtaq Feb 12, 2020

gzm0 Feb 12, 2020

gzm0 Feb 13, 2020

sjrd Feb 13, 2020

sjrd Feb 13, 2020

gzm0 Feb 14, 2020

sjrd Feb 14, 2020

gzm0 Feb 13, 2020

gzm0 Feb 13, 2020

gzm0 Feb 13, 2020

gzm0 Feb 13, 2020

sjrd commented Feb 14, 2020

gzm0 left a comment

gzm0 Feb 14, 2020

gzm0 Feb 14, 2020

gzm0 Feb 14, 2020

sjrd Feb 14, 2020

sjrd commented Feb 14, 2020

Labels

3 participants


		Scala.js 1.x consolidates all of that into one simple task key `jsEnvInput` of type `Seq[org.scalajs.jsenv.Input]`, where an `Input` is an ADT with the following possible alternatives:

		* `Input.Scripts(script)`: a JavaScript file to load as a script

Announcing Scala.js 1.0.0. #478

Announcing Scala.js 1.0.0. #478

Uh oh!

Conversation

sjrd commented Feb 11, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sjrd commented Feb 14, 2020

gzm0 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sjrd commented Feb 14, 2020

Labels

3 participants