Modernize the basic tutorial. #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* sbt 1.3.7, Scala 2.13.1, scalajs-dom 0.9.8, uTest 0.7.4. * Go back to scalajs-jquery because jquery-facade was not updated for Scala 2.13. * Update the links to downloads for sbt. * Mention Metals instead of Eclipse.
gzm0 reviewed Feb 10, 2020
| [debug] Starting process: node | ||
| [success] (...) | ||
| | ||
| So your code has actually been executed by Node.js. |
There was a problem hiding this comment.
Why was this section removed? At least this deserves mentioning in the commit message IMO.
There was a problem hiding this comment.
Yes, it was removed because that [debug] message doesn't appear anymore, so it's all pointless.
gzm0 approved these changes Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These changes go with the history at https://github.com/scala-js/scalajs-tutorial/commits/develop