Skip to content

Document causes of linking errors and how to fix them. #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2019
Merged

Document causes of linking errors and how to fix them. #457

merged 1 commit into from
Sep 14, 2019

Conversation

@sjrd
Copy link
Member

@sjrd sjrd commented Sep 13, 2019

@sjrd sjrd requested a review from gzm0 September 13, 2019 13:58
gzm0
gzm0 requested changes Sep 14, 2019
View reviewed changes
doc/project/linking-errors.md Outdated
## Using blocking APIs (e.g., `Await.result`)

The JavaScript platform does not support blocking at all.
Consequently, trying to use block APIs such `Await.result` is not supported, and will result in linking error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

result in a linking error?
doc/project/linking-errors.md
Do not use `scala.concurrent.Await`.


## Using unsupported JDK libraries (possibly transitively)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be helpful to make an example of a transitive problem (e.g. trying to use scala.io)
@sjrd sjrd force-pushed the document-linking-errors branch from 1516033 to bcece72 Compare September 14, 2019 13:34
@sjrd
Copy link
Member Author

sjrd commented Sep 14, 2019

Updated.
gzm0
gzm0 approved these changes Sep 14, 2019
View reviewed changes
Copy link
Contributor

@gzm0 gzm0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to write this! I expect this to be helpful to many.
@gzm0 gzm0 merged commit 8d873ed into scala-js:master Sep 14, 2019
@sjrd sjrd deleted the document-linking-errors branch February 13, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@sjrd @gzm0