Announcing Scala.js 0.6.14. #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member Author
| Review by @gzm0 |
gzm0 reviewed Dec 20, 2016
Contributor
gzm0 left a comment
gzm0 left a comment There was a problem hiding this comment.
Only a minor comment about the wording "top-level objects".
| {% endhighlight %} | ||
| | ||
| which allows to call `main()` from JavaScript. | ||
| `@JSExportTopLevel` methods must be declared in top-level `object`s. |
Contributor
There was a problem hiding this comment.
Are you deliberately saying top-level for simplicity here? @JSExportTopLevel is allowed in any static object.
Member Author
There was a problem hiding this comment.
Yes, it's deliberate. People don't know what a "static" object is, so a full sentence would be necessary. The verbosity is not worth it IMO.
| | ||
| While an `@JSExport`ed method inside an `@JSExport`ed object allows JavaScript code to call a "static" method, | ||
| it does not feel like a top-level function from JavaScript's point of view. | ||
| `@JSExportTopLevel` allows to export a method of a top-level object as a truly top-level function: |
Contributor
There was a problem hiding this comment.
Same comment about top-level here...
gzm0 approved these changes Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.