Skip to content

Conversation

@bbarker
Copy link
Contributor

@bbarker bbarker commented Sep 30, 2016

Note: I have not tested this, nor have I tested the library, but it looks to be somewhat well along and it is for an important library.

Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all. Make sure to amend your commit and force-push your branch after the fix. (don't create a second commit)

- name: Paper-Scala-js
url: https://github.com/yoeluk/paper-scala-js
desc: A Scala.js binding for [Paper.js](http://paperjs.org) - The Swiss Army Knife of Vector Graphics Scripting.
dep: '"com.github.yoeluk" %%% "paper-scala-js" % "0.5-SNAPSHOT"'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a new line at the end of the file, so that GitHub (and git) does not report this red mark?
(make sure not to add two new lines, because that would create a blank line at the end of file)

@bbarker bbarker force-pushed the paper-scala-js branch 2 times, most recently from 1ffa1bd to b0059ff Compare October 2, 2016 21:17
@bbarker
Copy link
Contributor Author

bbarker commented Oct 2, 2016

I tried adding one newline, using dos2unix, but I think I'll stop short of a using a hex editor if it still isn't working - feel free to manually merge - sorry!

@sjrd sjrd merged commit ce00753 into scala-js:master Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants