Skip to content

Conversation

katrinsharp
Copy link
Contributor

Adding testing page to documentation explaining unit testing in cross project as well as how to configure integration testing in cross project. Let me know what you think. /cc @ochrons

.htaccess Outdated
redirect 301 /doc/sbt/depending.html {{ BASE_PATH }}/doc/project/dependencies.html
redirect 301 /doc/sbt/js-envs.html {{ BASE_PATH }}/doc/project/js-environments.html
redirect 301 /doc/sbt/cross-building.html {{ BASE_PATH }}/doc/project/cross-build.html
redirect 301 /doc/sbt/testing.html {{ BASE_PATH }}/doc/project/testing.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed. IIUC, these are just so that links to the old site still work (a comment would have been useful indeed).

@katrinsharp
Copy link
Contributor Author

@gzm0 done - link to test section removed + comment about the file added

@gzm0
Copy link
Contributor

gzm0 commented Feb 18, 2016

@gzm0 done - link to test section removed + comment about the file added

Now I hope what I said is actually the case :P

@katrinsharp
Copy link
Contributor Author

@gzm0 I hope that someone will be able to approve/disapprove that, if not, then you're right anyways :)

@sjrd
Copy link
Member

sjrd commented Feb 18, 2016

IIUC, these are just so that links to the old site still work (a comment would have been useful indeed).

Yes, that's correct. We also add redirects when moving pages around, of course. So the comment, as written, is wrong.

But there should not be a new entry in redirects for a new page like this.

.htaccess Outdated
Change it ONLY if you deal with old site!
{% endcomment %}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The appropriate comment would be simply:

Redirects for pages that were moved around.

(whether from the old site or the new site is completely irrelevant)

@sjrd
Copy link
Member

sjrd commented Feb 18, 2016

I'll review the actual content later. I'm on a clock, right now.

.htaccess Outdated
Don't update this file if you are adding a new entry.
{% endcomment %}


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double blank line. (should be only 1)

@sjrd
Copy link
Member

sjrd commented Feb 27, 2016

That's all.

@katrinsharp
Copy link
Contributor Author

@sjrd I believe I addressed all your comments in latest push. Thanks

@sjrd
Copy link
Member

sjrd commented Mar 1, 2016

OK could you squash all the commits into 1, please?

@katrinsharp
Copy link
Contributor Author

Squashed to 1 commit per @sjrd request.

@sjrd
Copy link
Member

sjrd commented Mar 2, 2016

LGTM

sjrd added a commit that referenced this pull request Mar 2, 2016
@sjrd sjrd merged commit 28f5687 into scala-js:master Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants