- Notifications
You must be signed in to change notification settings - Fork 147
Update the docs for 0.6.5 and announce its release. #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review by everyone ;) |
Looks good to me. So many new things =D I guess after this we'll go and annotate all of scala-js-dom and other facade libraries with The visual asymmetry between |
Yes ^^
It is not nice, but remember that |
3df4ef0
to f82a5f6
Compare LGTM, and looking forward to it -- should seriously improve facade development... |
Looks good, thanks for this really useful release! |
👍 👏 👏 🎆
+100 :)
I missed this before , a handy one definitely . Out of curiosity we must implement all fields right ? ,not a replacer for companion objects/builder .. ? |
scala-js/scala-js#1883 is missing |
Yes, since Scala.js-defined JS traits cannot have concrete members, the Scala type system will basically force you to implement all advertised members. So for typical options object, that means you have to implement default values as well. Note that you could provide an
Indeed, thanks. And I also forgot scala-js/scala-js#1818 |
Artifacts published on Maven Central. ScalaDocs and CLI downloads up on the webserver. |
👯 🌹 try it out soon |
Updated with references to |
e5a4667
to 0ddccd6
Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider putting "in Scala.js" at the end of the phrase.
That's all. The SJS defined classes section is a bit minimalistic in some spots, but it's probably better to leave it until someone asks anyways :) |
OK I will make the changes before merging in 2/3 hours. |
Updated. |
Update the docs for 0.6.5 and announce its release.
Update the docs for 0.6.5 and announce its release.
The announcement is scheduled for Monday 31st morning CEST, assuming everything goes well with the release process.