Announcing Scala.js 0.6.4. #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Review by @nicolasstucki and all who want :-) |
There was a problem hiding this comment.
We should add a note on the simplifications in the concurrent collection due to single threading.
There was a problem hiding this comment.
Why? They completely respect their semantics. The simplifications are an implementation detail.
| Thats all. Otherwise LGTM |
| You forgot about the changed |
| Right. I'll add that. |
| Updated. |
| OK all ready. Will hit merge tomorrow morning CEST, before taking the train to the north of France. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.