static types for google maps v3 #155
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| OK, could you just amend the commit message so that it's something like
Note the capital and imperative "Add" as well as the ending dot. |
| done. |
Hum did you? I don't see anything changed. I still see "static types for google maps v3" as the commit message. |
| sorry I have now done a |
| Ah, somehow it all went wrong, and there's now a weird double commit + merge commit. Never mind, I'll fix it locally and push. |
| OK done. Thanks, and sorry for the fuss. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add scalajs-google-maps: static types for Google Maps v3.