Fix #152: Document option object pattern

[omidb]

adding Literal object construction using an scala object interface section to address http://stackoverflow.com/questions/26638171/how-do-i-create-options-objects-in-scala-js

Fix #152: Document option object pattern

[gzm0]

I would make this a title of lower order (###).

[gzm0]

"Scala" with capital first letter

[gzm0]

Also, consider making this section more about JS facades. Maybe even make the title: "Option objects for native JavaScript libraries"

[gzm0]

Thanks for the contribution.

[gzm0]

Please reference the issue in your commit message: "Fix #152: Document option object pattern". This will automatically establish the link between issue and PR.

[gzm0]

(this might also be a better commit title than " Update calling-javascript.md". git is able to tell me which files were altered. We don't need to duplicate that information in the commit message).

[gzm0]

That's all.

[omidb]

thanks for all comments.

[omidb]

@gzm0 I believe, I've addressed all of your points in 550d61c

[gzm0]

Maybe add an empty line?

[gzm0]

Also, Scala upper case, please.

[gzm0]

And "A" instead of "An" ("An" only if followed by a vovel).

[gzm0]

Also maybe say "should" instead of "can". And replace "easy access" (we don't really access, do we) by "type safe creation". (this is why one should do this, rather than scattering js.Dynamic.literal all over the code).

[gzm0]

That's all. Once you are done, please squash the commits into a single commit and give it the PR's title.

[omidb]

@gzm0 I don't have that much experience using Github, I was using the online editor and have no idea how can I squash the commits into a single commit!

[sjrd]

@omidb You'll have to do that using a local git client. After having cloned your fork, cd into its directory, then:

$ git remote add scalajs https://github.com/scala-js/scala-js-website.git 

and then you can rebase like this:

$ git checkout patch-1 $ git fetch scalajs $ git rebase -i scalajs/master 

Now in the editor that spawns, replace pick by squash (or just s) for all but the first line. Then save and quit the editor. The rebasing proceeds, and a new editor spawns to let you edit the commit message for the squashed commits. Do so (with the PR's title), then save and quit.
You can now force-push the branch:

$ git push -f origin patch-1 

[omidb]

@sjrd thanks for detailed instructions, I did it

[ochrons]

@omidb care to update this for the new site?

[omidb]

@ochrons sure, should I do anything? (I barely remember what happen :D )

[ochrons]

As things have changed and moved around quite a lot, it might be easiest to just make a new PR with the same content on the current document :)