Skip to content

Conversation

@gzm0
Copy link
Contributor

@gzm0 gzm0 commented Nov 19, 2014

No description provided.

@gzm0
Copy link
Contributor Author

gzm0 commented Nov 19, 2014

Review by @sjrd

@gzm0
Copy link
Contributor Author

gzm0 commented Nov 19, 2014

Please do not merge yet, I still need to upload the APIs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{{ BASE_PATH } missing } (found by CI)

@gzm0
Copy link
Contributor Author

gzm0 commented Nov 19, 2014

API is up

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a back port.
backport in 1 word?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will warn, if -> will warn if (no comma)
a @JSExport -> an @JSExport (when reading, @ begins with a vowel)
transitioning -> migrating

@sjrd
Copy link
Member

sjrd commented Nov 19, 2014

That's all.

@gzm0
Copy link
Contributor Author

gzm0 commented Nov 19, 2014

Updated

@sjrd
Copy link
Member

sjrd commented Nov 19, 2014

LGTM

@sjrd
Copy link
Member

sjrd commented Nov 19, 2014

Clear to announce?

sjrd added a commit that referenced this pull request Nov 19, 2014
@sjrd sjrd merged commit be6ecd7 into scala-js:master Nov 19, 2014
@gzm0 gzm0 deleted the release-0.5.6 branch December 12, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants