Skip to content

Implement polyfill for JSDOM #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 7, 2021
Merged

Implement polyfill for JSDOM #17

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df0689b
Implement polyfill for JSDOM
armanbilge Sep 7, 2021
0c1a7a6
Re-enable clamping test
armanbilge Sep 7, 2021
eb0ef22
Make detection logic more robust
armanbilge Sep 7, 2021
3d53d7a
formatting (please send help)
armanbilge Sep 7, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-enable clamping test
  • Loading branch information
@armanbilge
armanbilge committed Sep 7, 2021
commit 0c1a7a6465915a0dec64f21d537a2eeec4f67ebe
8 changes: 4 additions & 4 deletions core/src/test/scala/org/scalajs/macrotaskexecutor/MacrotaskExecutorSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ class MacrotaskExecutorSuite extends FunSuite {
else
Future.unit.flatMap(_ => loop(n - 1)).map(_ + 1)

// val start = System.currentTimeMillis()
// val MinimumClamp = 10000 * 2 * 4 // HTML5 specifies a 4ms clamp (https://developer.mozilla.org/en-US/docs/Web/API/WindowTimers.setTimeout#Minimum.2F_maximum_delay_and_timeout_nesting)
val start = System.currentTimeMillis()
val MinimumClamp = 10000 * 2 * 4 // HTML5 specifies a 4ms clamp (https://developer.mozilla.org/en-US/docs/Web/API/WindowTimers.setTimeout#Minimum.2F_maximum_delay_and_timeout_nesting)

loop(10000) flatMap { res =>
Future {
// val end = System.currentTimeMillis()
val end = System.currentTimeMillis()

assert(res == 10000)
// assert((end - start).toDouble / MinimumClamp < 0.25) // we should beat the clamping by at least 4x even on slow environments
assert((end - start).toDouble / MinimumClamp < 0.25) // we should beat the clamping by at least 4x even on slow environments
}
}
}
Expand Down