Add support for Web NFC API #806

FabioPinheiro · 2023-08-12T12:56:03Z

Web NFC API - https://developer.mozilla.org/en-US/docs/Web/API/Web_NFC_API

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala

dom/src/main/scala/org/scalajs/dom/NDEFRecord.scala

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala

dom/src/main/scala/org/scalajs/dom/NDEFMessage.scala

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala

armanbilge

Sorry, I've had some review comments "pending" for a week. I haven't finished looking at all the changes carefully, but here are my comments so far. Thanks for your work and your patience!

dom/src/main/scala/org/scalajs/dom/NDEFMessage.scala

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala

dom/src/main/scala/org/scalajs/dom/NDEFRecord.scala

dom/src/main/scala/org/scalajs/dom/NDEFMessage.scala

dom/src/main/scala/org/scalajs/dom/NDEFScanOptions.scala

dom/src/main/scala/org/scalajs/dom/NDEFWriteOptions.scala

dom/src/main/scala/org/scalajs/dom/NDEFRecord.scala

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala

FabioPinheiro · 2023-09-28T23:51:51Z

@armanbilge Thanks for the review
I only saw it today when I was updating the version of the lib.
If you could review it again would be much appreciated I have a couple of questions

armanbilge

I'm sorry, the example I linked was wrong 😕 all these defs should be vars.

dom/src/main/scala/org/scalajs/dom/NDEFWriteOptions.scala

dom/src/main/scala/org/scalajs/dom/NDEFScanOptions.scala

dom/src/main/scala/org/scalajs/dom/NDEFRecordInit.scala

Apply suggestions from code review Co-authored-by: zetashift <rskaraya@gmail.com> Co-authored-by: Arman Bilge <armanbilge@gmail.com>

armanbilge

Hmm, did you change those defs to vars? Some of them should be defs. If it is "read-only", then it is a def.

dom/src/main/scala/org/scalajs/dom/NDEFMessage.scala

dom/src/main/scala/org/scalajs/dom/NDEFReadingEvent.scala

dom/src/main/scala/org/scalajs/dom/NDEFRecord.scala

Co-authored-by: Arman Bilge <armanbilge@gmail.com>

FabioPinheiro · 2023-09-29T17:10:20Z

https://w3c.github.io/web-nfc/ format seems more clear to follow.
I did another review of all fields to seem if they are optional or not.
Hopefully everything is correct now.

zetashift

LGTM! Thank you for this awesome PR!

FabioPinheiro · 2023-11-26T16:18:38Z

Would be nice to have this merged before the next release

zetashift · 2023-12-21T20:21:43Z

@FabioPinheiro sorry for the wait, and thank you so much for this PR!

This comment was marked as outdated.

Sign in to view

FabioPinheiro commented Aug 12, 2023

View reviewed changes

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala Show resolved Hide resolved

FabioPinheiro commented Aug 12, 2023

View reviewed changes

dom/src/main/scala/org/scalajs/dom/NDEFRecord.scala Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

FabioPinheiro commented Aug 12, 2023

View reviewed changes

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala Outdated Show resolved Hide resolved

FabioPinheiro force-pushed the Web_NFC_API branch from c3d4f22 to 0072cb8 Compare August 12, 2023 14:15

FabioPinheiro changed the title ~~[WIP] Add support for Web NFC API~~ Add support for Web NFC API Aug 12, 2023

FabioPinheiro added a commit to FabioPinheiro/scala-did that referenced this pull request Aug 16, 2023

scala-js/scala-js-dom#806: Add support for Web NFC API

89966dc

zetashift reviewed Aug 19, 2023

View reviewed changes

dom/src/main/scala/org/scalajs/dom/NDEFMessage.scala Outdated Show resolved Hide resolved

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala Outdated Show resolved Hide resolved

FabioPinheiro force-pushed the Web_NFC_API branch from 599b9c5 to a34b0bd Compare August 20, 2023 23:37

FabioPinheiro requested a review from zetashift August 20, 2023 23:38

armanbilge reviewed Aug 21, 2023

View reviewed changes

dom/src/main/scala/org/scalajs/dom/NDEFMessage.scala Outdated Show resolved Hide resolved

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala Outdated Show resolved Hide resolved

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala Outdated Show resolved Hide resolved

FabioPinheiro force-pushed the Web_NFC_API branch 2 times, most recently from 0742064 to d6dce7c Compare August 22, 2023 00:17

FabioPinheiro added a commit to FabioPinheiro/scala-did that referenced this pull request Aug 22, 2023

After update PR scala-js/scala-js-dom#806

a753c1a

FabioPinheiro force-pushed the Web_NFC_API branch from d6dce7c to e034e26 Compare August 22, 2023 19:56

zetashift reviewed Aug 22, 2023

View reviewed changes

dom/src/main/scala/org/scalajs/dom/NDEFReader.scala Outdated Show resolved Hide resolved

zetashift reviewed Aug 22, 2023

View reviewed changes

dom/src/main/scala/org/scalajs/dom/NDEFRecord.scala Outdated Show resolved Hide resolved

FabioPinheiro force-pushed the Web_NFC_API branch from 3524a12 to effb33f Compare August 22, 2023 21:47

FabioPinheiro added a commit to FabioPinheiro/scala-did that referenced this pull request Aug 24, 2023

Reflex change on scala-js/scala-js-dom#806

07359b1

armanbilge reviewed Sep 17, 2023

View reviewed changes

FabioPinheiro mentioned this pull request Sep 28, 2023

Update scalajs-dom to 2.8.0 FabioPinheiro/scala-did#150

Merged

FabioPinheiro force-pushed the Web_NFC_API branch from 69ac9a1 to 1cc5447 Compare September 28, 2023 23:49

armanbilge reviewed Sep 29, 2023

View reviewed changes

Add support for Web NFC API

bd14f33

Apply suggestions from code review Co-authored-by: zetashift <rskaraya@gmail.com> Co-authored-by: Arman Bilge <armanbilge@gmail.com>

FabioPinheiro force-pushed the Web_NFC_API branch from 23c2c77 to bd14f33 Compare September 29, 2023 14:38

armanbilge reviewed Sep 29, 2023

View reviewed changes

FabioPinheiro and others added 2 commits September 29, 2023 16:47

Apply suggestions from code review

4f7043a

Co-authored-by: Arman Bilge <armanbilge@gmail.com>

Add trait NDEFReadingEventInit and other fixes

65a35e3

FabioPinheiro added a commit to FabioPinheiro/scala-did that referenced this pull request Sep 29, 2023

Reflect changes in scala-js/scala-js-dom#806 after review

07fd6ce

FabioPinheiro added a commit to FabioPinheiro/scala-did that referenced this pull request Sep 29, 2023

Reflect changes in scala-js/scala-js-dom#806

b3f5fc8

zetashift approved these changes Oct 14, 2023

View reviewed changes

armanbilge self-requested a review November 26, 2023 17:16

zetashift merged commit 6c9e6b6 into scala-js:main Dec 21, 2023

zetashift mentioned this pull request Dec 21, 2023

fix: NDEFReadingEventInit.serialNumber returns a string #825

Merged

FabioPinheiro mentioned this pull request Jul 28, 2025

Update scalajs-dom to 2.8.1 FabioPinheiro/scala-did#432

Draft

Add support for Web NFC API #806

Add support for Web NFC API #806

Uh oh!

Conversation

FabioPinheiro commented Aug 12, 2023

This comment was marked as outdated.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

armanbilge left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabioPinheiro commented Sep 28, 2023

armanbilge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

armanbilge left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FabioPinheiro commented Sep 29, 2023

zetashift left a comment

Choose a reason for hiding this comment

FabioPinheiro commented Nov 26, 2023

zetashift commented Dec 21, 2023

Labels

3 participants

armanbilge left a comment •

edited

Loading