add Path2D and related methods #769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
armanbilge reviewed Mar 28, 2023
armanbilge reviewed Mar 29, 2023
| | ||
| def fill(path: Path2D): Unit = js.native | ||
| | ||
| def fill(fillRule: String): Unit = js.native |
There was a problem hiding this comment.
It looks like fillRule can be either "nonzero" or "evenodd" so we should model like other "enums".
Comment on lines +6 to +8
| @js.native | ||
| @JSGlobal | ||
| class Path2D extends js.Object { |
There was a problem hiding this comment.
The [[Path2D]] interface of the Canvas 2D API is used to declare a path that can then be used on a [[CanvasRenderingContext2D]] object. | * clockwise). | ||
| */ | ||
| def ellipse(x: Double, y: Double, radiusX: Double, radiusY: Double, rotation: Double, startAngle: Double, | ||
| endAngle: Double, anticlockwise: Boolean = js.native): Unit = js.native |
There was a problem hiding this comment.
Seems to be called counterclockwise in the spec.
Suggested change
| endAngle: Double, anticlockwise: Boolean = js.native): Unit = js.native | |
| endAngle: Double, counterclockwise: Boolean = js.native): Unit = js.native |
Comment on lines 42 to 43
| def arc(x: Double, y: Double, radius: Double, startAngle: Double, endAngle: Double, | ||
| anticlockwise: Boolean): Unit = js.native |
There was a problem hiding this comment.
Suggested change
| def arc(x: Double, y: Double, radius: Double, startAngle: Double, endAngle: Double, | |
| anticlockwise: Boolean): Unit = js.native | |
| def arc(x: Double, y: Double, radius: Double, startAngle: Double, endAngle: Double, | |
| counterclockwise: Boolean): Unit = js.native |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi there!
Before submitting a PR containing any Scala changes, please make sure you...
sbt prePRapi-reportsThanks for contributing!