Restore scalafix task to prePR #525
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
japgolly reviewed Aug 30, 2021
Contributor
| Oh wooooooooooooow, nice idea!! I didn't think of that. |
japgolly requested changes Aug 30, 2021
Contributor
japgolly left a comment
japgolly left a comment There was a problem hiding this comment.
Simple and elegant! Just 2 tiny changes requested.
build.sbt Outdated
| if (scalaVersion.value.startsWith("2.")) | ||
| (root / Compile / scalafix).toTask("") | ||
| else | ||
| Def.task(()) |
Contributor
There was a problem hiding this comment.
Could we change this to root / Compile / compile so that Scala 3 does a recompile after scalafmt? (I have had a few rare bad experiences and even though quite rare, I want to catch that if they pop up again)
build.sbt Outdated
| root / Compile / scalafmt, | ||
| root / Compile / compile, | ||
| Def.taskDyn { | ||
| if (scalaVersion.value.startsWith("2.")) |
Contributor
There was a problem hiding this comment.
Could we indent this whole block within Def.taskDyn
Member Author
| Oops, seems I buggered this, fixing... |
japgolly reviewed Aug 30, 2021
build.sbt Outdated
| if (scalaVersion.value.startsWith("2.")) | ||
| (root / Compile / scalafix).toTask("") | ||
| else | ||
| (root / Compile / compile).toTask("") |
Contributor
There was a problem hiding this comment.
Is this the problem?
Suggested change
| (root / Compile / compile).toTask("") | |
| root / Compile / compile |
Member Author
There was a problem hiding this comment.
Thanks, tried that already. Tbh I'm a bit stumped, never quite made friends with sbt lol.
armanbilge commented Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Will fix #524.
Currently fails with: