- Notifications
You must be signed in to change notification settings - Fork 159
Support scala 3 #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Support scala 3 #446
Changes from 2 commits
Commits
Show all changes
25 commits Select commit Hold shift + click to select a range
344bb13 suport scala 3.0.0-RC1
russwyte ad63fe5 scalafm
russwyte 5910767 override constructors where appropriate
russwyte 5079836 scalafmt
russwyte d8abc03 update CI pipeline
russwyte 4397c7b update CI pipeline
russwyte bf33bf1 exclude 2.13.5 from 0.6.28 build
russwyte f561225 also need to exlude scala 3 from 0.6.28
russwyte 0425741 fix conflicts
russwyte 9606d60 update CI to inlude all supported versions
russwyte 28eeb7d don't use 2.13.5
russwyte 3c0e714 remove jcenter
russwyte d15c21b put back jcenter repo
russwyte 7d70b3d use include instead of exclude
russwyte ea04026 clean before package
russwyte b8c4311 need to quute
russwyte 47cc047 clean before compiling example
russwyte fb8188a update to Scala 3.0.0-RC2
russwyte d70eaa0 punt and use asInstanceOf to avoid breaking change
russwyte f594b66 fix ci.yml so that it has the correct scala 3 version
russwyte 5176b44 scalafmt
russwyte f77e53a scala 3.0.0 FTW
russwyte ed3ad20 get scaladocs for scala 3 working
russwyte 0432c8f scalafmt and bump scala 3 version
russwyte cf5e4e7 update scala to release version 3.0.1
russwyte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| sbt.version=1.2.8 | ||
| sbt.version=1.5.0-M2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| package org.scalajs.dom | ||
| | ||
| import scala.language.implicitConversions | ||
| | ||
| Comment on lines 3 to -4 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please keep this empty line. We always keep | ||
| import scala.collection.mutable | ||
| import scala.runtime.RichDouble | ||
| | ||
| package object ext { | ||
| | ||
| | @@ -22,17 +22,18 @@ package object ext { | |
| def cast[T] = x.asInstanceOf[T] | ||
| } | ||
| | ||
| implicit def pimpAnimatedNumber(x: svg.AnimatedNumber) = x.baseVal | ||
| implicit def pimpAnimatedNumber(x: svg.AnimatedNumber): Double = x.baseVal | ||
| | ||
| implicit def pimpRichAnimatedNumber(x: svg.AnimatedNumber) = | ||
| implicit def pimpRichAnimatedNumber(x: svg.AnimatedNumber): RichDouble = | ||
| x.baseVal: runtime.RichDouble | ||
| | ||
| implicit def pimpAnimatedLength(x: svg.AnimatedLength) = x.baseVal.value | ||
| implicit def pimpAnimatedLength(x: svg.AnimatedLength): Double = | ||
| x.baseVal.value | ||
| | ||
| implicit def pimpRichAnimatedLength(x: svg.AnimatedLength) = | ||
| implicit def pimpRichAnimatedLength(x: svg.AnimatedLength): RichDouble = | ||
| x.baseVal.value: runtime.RichDouble | ||
| | ||
| implicit def color2String(c: Color) = c.toString | ||
| implicit def color2String(c: Color): String = c.toString | ||
| implicit class pimpedContext(val ctx: CanvasRenderingContext2D) { | ||
| def prepCircle(x: Double, y: Double, r: Double) = { | ||
| ctx.beginPath() | ||
| | ||
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.