Fix #376: Add the Fullscreen API #402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sjrd requested changes Mar 23, 2020
| var onfullscreenerror: js.Function1[Event, _] = js.native | ||
| } | ||
| | ||
| class FullscreenOptions( |
There was a problem hiding this comment.
According to MDN, this should be a trait with a var navigationUI instead of a class.
| * MDN | ||
| */ | ||
| def requestFullscreen( | ||
| options: FullscreenOptions = ???): js.Promise[Unit] = js.native |
There was a problem hiding this comment.
Prefer js.native instead of ??? for default values in JS APIs:
Suggested change
| options: FullscreenOptions = ???): js.Promise[Unit] = js.native | |
| options: FullscreenOptions = js.native): js.Promise[Unit] = js.native |
sjrd approved these changes Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #376