Upgrade to Scala.js 1.0.0 and make it the default. #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sjrd requested changes Feb 6, 2020
.travis.yml Outdated
| env: | ||
| - SCALAJS_VERSION=0.6.28 | ||
| - SCALAJS_VERSION=1.0.0-RC2 | ||
| - SCALAJS_VERSION=0.6.32 |
There was a problem hiding this comment.
Please don't change the version of 0.6.x. We intentionally build and publish for older versions as long as possible, to allow people using older versions of Scala.js 0.6.x to use scalajs-dom.
There was a problem hiding this comment.
Ok, updated only 1.0.0.
exoego force-pushed the scalajs-update branch from f38bf95 to 23ec24e Compare sjrd approved these changes Feb 6, 2020
sjrd changed the title 
| Thanks :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.