Skip to content

Fix #219: Fix Event constructors. #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 16, 2019
Merged

Fix #219: Fix Event constructors. #367

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5daceab
Add event constructors that accepts type name and init
May 15, 2019
8a85b9a
Deprecate object companion defined for limited number of ***EventInit
May 15, 2019
1c90901
MutationEvent has no constructor
May 15, 2019
882c079
Prefer import instead of qualified name at use site
May 15, 2019
dde36b2
Format blank lines
May 15, 2019
4457811
No need to limit to js.Any since data can be anything
May 15, 2019
b7194a5
Use js.native for argument that is not taken into account at runtime.
May 15, 2019
879d4ae
MutationEvent has no constructor
May 15, 2019
7f98757
No need to limit to js.Any since data can be anything
May 15, 2019
9e80c81
Workaround for deprecation warning on var
May 16, 2019
96938be
Remove unused trait
May 16, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
No need to limit to js.Any since data can be anything
  • Loading branch information
exoego committed May 15, 2019
commit 44578113bd8c569bf68e9c1c5cfdc484d49df12a
4 changes: 2 additions & 2 deletions src/main/scala/org/scalajs/dom/experimental/serviceworkers/ServiceWorkers.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ class ExtendableEvent(typeArg: String, init: js.UndefOr[ExtendableEventInit])
}

trait ExtendableMessageEventInit extends ExtendableEventInit {
var data: js.UndefOr[js.Any] = js.undefined
var data: js.UndefOr[Any] = js.undefined

var origin: js.UndefOr[String] = js.undefined

Expand All @@ -444,7 +444,7 @@ class ExtendableMessageEvent(typeArg: String,
/**
* Returns the event's data. It can be any data type.
*/
val data: js.Any = js.native
val data: Any = js.native

/**
* Returns the origin of the service worker's environment settings object.
Expand Down
15 changes: 8 additions & 7 deletions src/main/scala/org/scalajs/dom/raw/lib.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3556,7 +3556,7 @@ abstract class Document
trait MessageEventInit extends EventInit {
var source: js.UndefOr[Window] = js.undefined
var origin: js.UndefOr[String] = js.undefined
var data: js.UndefOr[String | Blob | ArrayBuffer] = js.undefined
var data: js.UndefOr[Any] = js.undefined
}

/**
Expand All @@ -3575,17 +3575,18 @@ class MessageEvent(typeArg: String, init: js.UndefOr[MessageEventInit])
def origin: String = js.native

/**
* The data from the server (`String`, [[Blob]], or `ArrayBuffer`)
* The data you want contained in the MessageEvent.
*
* This can be of any data type, and will default to null if not specified.
*
* MDN
*/
def data: String | Blob | ArrayBuffer = js.native
def data: Any = js.native

@deprecated("Non-standard", "forever")
def initMessageEvent(typeArg: String, canBubbleArg: Boolean,
cancelableArg: Boolean, dataArg: String | Blob | ArrayBuffer,
originArg: String, lastEventIdArg: String,
sourceArg: Window): Unit = js.native
cancelableArg: Boolean, dataArg: Any, originArg: String,
lastEventIdArg: String, sourceArg: Window): Unit = js.native

def ports: js.Any = js.native
}
Expand Down Expand Up @@ -5718,7 +5719,7 @@ class StyleSheetList extends js.Object {
}

trait CustomEventInit extends EventInit {
var detailArg: js.UndefOr[js.Any] = js.undefined
var detailArg: js.UndefOr[Any] = js.undefined
}

/**
Expand Down