Add showNotification/getNotifications to ServiceWorkerRegistration #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sjrd requested changes Mar 18, 2018
| * | ||
| * MDN | ||
| */ | ||
| def showNotification(title: String, options: NotificationOptions = ???): js.Promise[Event] = js.native |
There was a problem hiding this comment.
The result type should be js.Promise[Unit], not js.Promise[Event]. The spec says that the promise is completed with undefined, whose type in Scala.js is Unit.
There was a problem hiding this comment.
oops, sorry for the oversight
| * | ||
| * MDN | ||
| */ | ||
| def getNotifications(options: GetNotificationOptions = ???): js.Promise[js.Array[Notification]] = js.native |
There was a problem hiding this comment.
You should use Sequence instead of js.Array here. (Sequence is defined here)
cornerman force-pushed the serviceworker-registration-notification branch from 89b0fac to 3f1bbd6 Compare sjrd approved these changes Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Specification: