Add applicationServerKey to PushSubscriptionOptions #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sjrd reviewed Mar 18, 2018
| js.Dynamic | ||
| .literal("userVisibleOnly" -> userVisibleOnly, "applicationServerKey" -> applicationServerKey) | ||
| .asInstanceOf[PushSubscriptionOptions] | ||
| } |
There was a problem hiding this comment.
It would be better to turn PushSubscriptionOptions into a non-native JS trait with = js.undefined, and let users do
new PushSubscriptionOptions { userVisibleOnly = ... applicationServerKey = ... }The apply method-based pattern is old; we do not use it anymore.
cornerman force-pushed the push-subscription-server-key branch from 4840b6d to b17d33c Compare sjrd requested changes Mar 18, 2018
| } | ||
| var userVisibleOnly: js.UndefOr[Boolean] = js.undefined | ||
| var applicationServerKey: js.UndefOr[Uint8Array] = js.undefined | ||
| } |
There was a problem hiding this comment.
Ah, good, but we'll need to keep the existing PushSubscriptionOptions.apply for backward binary compatibility. You can deprecate it, though.
There was a problem hiding this comment.
Oh, that makes sense
cornerman force-pushed the push-subscription-server-key branch from b17d33c to 26971f5 Compare 
| It wants some |
cornerman force-pushed the push-subscription-server-key branch from 26971f5 to 49e81cc Compare - turn PushSubscriptionOptions into a non-native JS trait
| I need to start remembering this step :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Link to specification