Skip to content

Conversation

@sjrd
Copy link
Member

sjrd commented Dec 13, 2016

You should deprecate the type aliases instead of disabling fatal warnings.

@danielnixon
Copy link
Contributor Author

Done (and squashed).

@sjrd
Copy link
Member

sjrd commented Jan 16, 2017

The first two commits should be squashed together, because the first one doesn't build on its own.

The commit message of the third commit doesn't make sense to me wrt. the contents of the commit.

Maybe it's better to just squash everything together, here, as everything is about deprecations anyway.

See: * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/bgsound * https://msdn.microsoft.com/en-us/library/windows/apps/hh965347.aspx * https://developer.mozilla.org/en-US/docs/Web/API/window/setImmediate * https://developer.mozilla.org/en-US/docs/Web/API/Window/clearImmediate * https://developer.mozilla.org/en/docs/Web/API/Event/srcElement * https://msdn.microsoft.com/en-us/library/hh869721(v=vs.85).aspx * https://www.w3.org/TR/html5/obsolete.html * https://developer.mozilla.org/en-US/docs/Web/API/HTMLFontElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLBaseFontElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLHeadElement * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dir * https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent/initAnimationEvent * https://developer.mozilla.org/en-US/docs/Web/API/HTMLFrameSetElement * https://developer.mozilla.org/en-US/docs/Web/HTML/Element/frame * https://developer.mozilla.org/en/docs/Web/API/HTMLTableCellElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableRowElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableColElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLDivElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLHRElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLHeadingElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLParagraphElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableCaptionElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement * https://developer.mozilla.org/en-US/docs/Web/API/Document/applets * https://developer.mozilla.org/en-US/docs/Web/API/HTMLAreaElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLIFrameElement * https://msdn.microsoft.com/en-us/library/ff521069(v=vs.85).aspx * https://developer.mozilla.org/en-US/docs/Web/API/HTMLTableSectionElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLAnchorElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLParamElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLPreElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLBRElement * https://developer.mozilla.org/en-US/docs/Web/API/HTMLObjectElement * https://dom.spec.whatwg.org/#dom-traversal-changes * https://dom.spec.whatwg.org/#nodeiterator * https://dom.spec.whatwg.org/#treewalker * https://dom.spec.whatwg.org/#htmlcollection
@danielnixon
Copy link
Contributor Author

I think the build failure was because Travis couldn't resolve some dependencies.

Everything squashed. Thanks @sjrd !

@sjrd sjrd merged commit e3ddc58 into scala-js:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants