Skip to content

Add Gamepad API. #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2016
Merged

Add Gamepad API. #213

merged 1 commit into from
Feb 15, 2016

Conversation

@mseddon
Copy link
Contributor

@mseddon mseddon commented Feb 15, 2016

@sjrd
Copy link
Member

sjrd commented Feb 15, 2016

Most of these things should be top-level in the package, rather than in the package object.
Basically everything but the implicit pimp of Navigator.
@mseddon
Copy link
Contributor Author

mseddon commented Feb 15, 2016

Doh, good point. I kept the GamepadMappingType literals as final vals in the package though, for lack of a better place to put them (perhaps in a Gamepad companion object, if you feel they should not be in that package).
sjrd
sjrd reviewed Feb 15, 2016
View reviewed changes
src/main/scala/org/scalajs/dom/experimental/gamepad/Gamepad.scala Outdated
import scala.scalajs.js
import scala.scalajs.js.annotation.JSName

trait GamepadMappingType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must extend js.Any.
@sjrd
Copy link
Member

sjrd commented Feb 15, 2016

That's all.
@mseddon
Copy link
Contributor Author

mseddon commented Feb 15, 2016

Updated.
@sjrd
Copy link
Member

sjrd commented Feb 15, 2016

LGTM
sjrd added a commit that referenced this pull request Feb 15, 2016
@sjrd
Merge pull request #213 from mseddon/gamepad-api
195c54e 
Add Gamepad API.
@sjrd sjrd merged commit 195c54e into scala-js:master Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mseddon @sjrd