Fix #198: Make WebGL constants final vals to support Safari. #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
These two guys were missing.
| That's all. |
mseddon force-pushed the webgl-safari-fix branch from 3141a03 to 3f0f088 Compare 
| Changed as requested. |
| LGTM |
sjrd added a commit that referenced this pull request Jan 18, 2016
Fix #198: Make WebGL constants final vals to support Safari.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This has been tested against my current code and appears to now behave correctly under Safari as well as Chrome. Also I found two enums that I'd apparently missed when initially creating the facade, so they've been added, too.